Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update session #79

Merged
merged 10 commits into from
Aug 14, 2022
Merged

ENH: Update session #79

merged 10 commits into from
Aug 14, 2022

Conversation

Miksus
Copy link
Owner

@Miksus Miksus commented Aug 13, 2022

This PR has the following changes:

  • Now session should be passed to task classes. Else, empty session is created.
  • Deprecated session.get_task

@Miksus Miksus added enhancement New feature or request core Relates to the core functionalities (ie. base classes) labels Aug 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2022

Codecov Report

Merging #79 (9168608) into master (05861b7) will increase coverage by 0.03%.
The diff coverage is 97.91%.

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   91.10%   91.13%   +0.03%     
==========================================
  Files          88       88              
  Lines        4339     4366      +27     
==========================================
+ Hits         3953     3979      +26     
- Misses        386      387       +1     
Impacted Files Coverage Δ
rocketry/core/task.py 93.01% <87.50%> (+0.05%) ⬆️
rocketry/__init__.py 100.00% <100.00%> (ø)
rocketry/application.py 84.21% <100.00%> (+2.12%) ⬆️
rocketry/core/schedule.py 89.65% <100.00%> (-0.35%) ⬇️
rocketry/session.py 91.94% <100.00%> (+0.43%) ⬆️
rocketry/utils/dependencies.py 84.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Miksus Miksus merged commit 18d0cb1 into master Aug 14, 2022
@Miksus Miksus deleted the dev/update_session branch August 14, 2022 09:20
@Miksus Miksus mentioned this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Relates to the core functionalities (ie. base classes) enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants