allow more flexible dependency versions #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently conflicts can arise when using contextualized-topic-models with other libraries requiring newer versions of libraries. This puts a lower bound on dep versions.
|
@vinid I'm not sure if you're the right person to review, but maybe you have ideas if not. I'd love to see this land and perhaps v2.1.2 could be cut. I'm trying to use this and have many deprecation warnings in my code -- not the end of the world, but certainly not very nice. This PR seeks to address that. |
|
Hello @erip! Thanks for this! It makes total sense to allow for more flexibility. I'll merge your PR. I have one or two fixes to add to the current codebase and I'll then release a new version |
|
Thanks so much, @vinid! I've found a couple of other issues worth fixing, but I'll raise an issue first after doing some quick troubleshooting. They're fairly minor, so no worries if they don't make it into 2.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently conflicts can arise when using contextualized-topic-models with other libraries requiring newer versions of libraries. This puts a lower bound on dep versions.