Change "best" model_selection to include a loss threshold #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…ilesCranmer/PySR into improved-model-selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PySR
v0.10.0, this should change the definition ofmodel_selection="best"to also include a loss threshold. Sometimes, just returning the equation with the max score will have a very bad loss - perhaps because a very simple equation just happens to have a large derivative in the loss-complexity curve.This PR changes this so that only equations with
loss < 1.5 * min_lossare considered. This is what was used by PySR in the GECCO contest and seemed to work well in that situation.To select purely based on score, one can now use
model_selection="score"This PR also refactors the model_selection to avoid shotgun edits.