New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix TypeError when a variable name matches a builtin python function #558
Conversation
…nction Example: A dataset with a column named 'exec' failed with: ValueError: Error from parse_expr with transformed code: "(Float ('86.76248' )-exec )" ... snip ... TypeError: unsupported operand type(s) for -: 'Float' and 'builtin_function_or_method'
Thanks! |
@tomjelen can you enable push access for maintainers? Then I can edit the PR directly. |
Hey there, thanks for looking into the failed build. I don't have much experience with Conda, so could take me a while to figure out whats going on. "Allow edits by maintainers" is checked. That's what you need right? |
Perfect, thanks! The segfault looks to be unrelated. Sometimes the GitHub action runners simply don't enough memory to use for the builds. But I will take a look. |
Hm, nope, it's still not letting me push to your branch. It says
I'll try to figure this out... Not sure why it's doing that I can also make a new PR from my local branch if needed, including your commit as the base. |
Nevermind, seems like it was some issue on my side with remotes and what URL I used... Sorry for the confusion |
Ah, okay. No worries :) |
For example, fitting on a dataset with a column named 'exec' fails with:
This change maps the feature names to sympy.Symbol when parsing the pysr-equation in
pysr2sympy
.