New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split codebase in two: DynamicExpressions.jl and SymbolicRegression.jl #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilesCranmer
force-pushed
the
split-to-dynamic-expressions
branch
from
October 22, 2022 08:21
2bbcc6a
to
46bd4eb
Compare
MilesCranmer
force-pushed
the
split-to-dynamic-expressions
branch
from
October 23, 2022 02:33
97fb30d
to
05c6137
Compare
MilesCranmer
force-pushed
the
split-to-dynamic-expressions
branch
from
October 23, 2022 02:48
05c6137
to
c3b0987
Compare
MilesCranmer
commented
Oct 23, 2022
Seems like it fails a lot for the state saving test, and might even segfault. I guess there’s some state that’s not being initialized correctly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the entire codebase in two:
Node
type, and the evaluation kernels.This reduces the code complexity quite a bit, and makes it easier to focus on the actual evolutionary algorithm in one codebase, and an efficient expression evaluation scheme in the other codebase. Already by porting DynamicExpressions.jl into its own codebase, I've found it's easier to get tensor-based evaluation up-and-running! See the README example for one where I even define an expression on strings and then evaluate it: https://github.com/SymbolicML/DynamicExpressions.jl.
In the future it would be great if SymbolicRegression.jl was completely generic to type. A good test scenario of this would be: can I optimize a string, using a set of operators on strings, to have a particular loss metric?
This will then make it super easy to get a tensor version of symbolic regression working.
TODO:
expression(X)
.LinearAlgebra
is no longer imported here)