Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLJ Integration #226

Merged
merged 66 commits into from
Jul 5, 2023
Merged

MLJ Integration #226

merged 66 commits into from
Jul 5, 2023

Commits on Jul 4, 2023

  1. Clean up printing in Options

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    1b963d1 View commit details
    Browse the repository at this point in the history

  2. Working MLJModelInterface integration

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    1c241e0 View commit details
    Browse the repository at this point in the history

  3. Return more report keys

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3cea91f View commit details
    Browse the repository at this point in the history

  4. Formatting

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    6239790 View commit details
    Browse the repository at this point in the history

  5. Move selection functions

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    82a8c0b View commit details
    Browse the repository at this point in the history

  6. Have user pass full Options() to MLJ model

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    7df1309 View commit details
    Browse the repository at this point in the history

  7. Fix import order of MLJ

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3b7e3a7 View commit details
    Browse the repository at this point in the history

  8. Deprecate return_state in options

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    32b2003 View commit details
    Browse the repository at this point in the history

  9. Formatting

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    a298e13 View commit details
    Browse the repository at this point in the history

  10. Automatically forward all option kwargs to MLJ

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    edfb424 View commit details
    Browse the repository at this point in the history

  11. Store Options in fitresult to avoid recreation

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    6cc15d3 View commit details
    Browse the repository at this point in the history

  12. Fix incorrect deprecated kwarg

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    afe571f View commit details
    Browse the repository at this point in the history

  13. Rename import to MMI

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    b70fbfd View commit details
    Browse the repository at this point in the history

  14. Add MLJ metadata

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    0be9e29 View commit details
    Browse the repository at this point in the history

  15. Add test of MLJ interface

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    5047355 View commit details
    Browse the repository at this point in the history

  16. Turn off variable_names == keys behavior 

    - Seems that `keys` of an array is the indices
    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    0509ee1 View commit details
    Browse the repository at this point in the history

  17. Fix MLJ output for multi-out

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    1ccf2c1 View commit details
    Browse the repository at this point in the history

  18. Formatting

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    d54f515 View commit details
    Browse the repository at this point in the history

  19. Get iterative model fits to work with MLJ

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    05426d1 View commit details
    Browse the repository at this point in the history

  20. Expand target_scitype to include tables

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    7f746fc View commit details
    Browse the repository at this point in the history

  21. Specify input types in Options constructor

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    4d7a102 View commit details
    Browse the repository at this point in the history

  22. Missing parentheses

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    19da06b View commit details
    Browse the repository at this point in the history

  23. Only continuous input allowed

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    d4d1e67 View commit details
    Browse the repository at this point in the history

  24. Split into MultiSRRegressor for multi-output

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    a4b43d4 View commit details
    Browse the repository at this point in the history

  25. Test MultiSRRegressor

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    8265113 View commit details
    Browse the repository at this point in the history

  26. Undo typing of operators

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    14834bb View commit details
    Browse the repository at this point in the history

  27. Other typing fixes

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    03ac6c7 View commit details
    Browse the repository at this point in the history

  28. Allow npopulations to be nothing

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f519d63 View commit details
    Browse the repository at this point in the history

  29. Automatically get column names using MMI.schema

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    945bbc8 View commit details
    Browse the repository at this point in the history

  30. Fix getcolnames

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    8cb7625 View commit details
    Browse the repository at this point in the history

  31. Update src/MLJInterface.jl 

    Co-authored-by: Okon Samuel <39421418+OkonSamuel@users.noreply.github.com>
    @MilesCranmer @OkonSamuel
    MilesCranmer and OkonSamuel committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    75ff44b View commit details
    Browse the repository at this point in the history

  32. Rename to MultitargetSRRegressor 

    Co-authored-by: Okon Samuel <39421418+OkonSamuel@users.noreply.github.com>
    @MilesCranmer @OkonSamuel
    MilesCranmer and OkonSamuel committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    2af66b7 View commit details
    Browse the repository at this point in the history

  33. Formatting

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    bab79e2 View commit details
    Browse the repository at this point in the history

  34. Ensure matrices respect column-major

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    5680300 View commit details
    Browse the repository at this point in the history

  35. Brute force way to get column names

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    af441c4 View commit details
    Browse the repository at this point in the history

  36. Copy the correct way 

    Co-authored-by: Okon Samuel <39421418+OkonSamuel@users.noreply.github.com>
    @MilesCranmer @OkonSamuel
    MilesCranmer and OkonSamuel committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    734e34b View commit details
    Browse the repository at this point in the history

  37. Copy the correct way using permutedims 

    Co-authored-by: Okon Samuel <39421418+OkonSamuel@users.noreply.github.com>
    @MilesCranmer @OkonSamuel
    MilesCranmer and OkonSamuel committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    2edbcb4 View commit details
    Browse the repository at this point in the history

  38. Safety check for SRRegressor

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    e567a24 View commit details
    Browse the repository at this point in the history

  39. Fix copying in prediction as well 

    Co-authored-by: Okon Samuel <39421418+OkonSamuel@users.noreply.github.com>
    @MilesCranmer @OkonSamuel
    MilesCranmer and OkonSamuel committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    08456ff View commit details
    Browse the repository at this point in the history

  40. Update src/MLJInterface.jl 

    Co-authored-by: Okon Samuel <39421418+OkonSamuel@users.noreply.github.com>
    @MilesCranmer @OkonSamuel
    MilesCranmer and OkonSamuel committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    0e95937 View commit details
    Browse the repository at this point in the history

  41. Fix variable_names and pass to report as well

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f96751c View commit details
    Browse the repository at this point in the history

  42. Add variable names test

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    50bfaec View commit details
    Browse the repository at this point in the history

  43. Allow normal matrix input to models

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    47fdb69 View commit details
    Browse the repository at this point in the history

  44. Add test of predictions

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    7a16f7c View commit details
    Browse the repository at this point in the history

  45. Add tests for helpful error messages

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    2222347 View commit details
    Browse the repository at this point in the history

  46. Use metadata_pkg and metadata_model instead

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    6139bba View commit details
    Browse the repository at this point in the history

  47. Avoid ndims for better portability

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    e585bd4 View commit details
    Browse the repository at this point in the history

  48. Missing predict import

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    38758dc View commit details
    Browse the repository at this point in the history

  49. Clean up metadata_pkg

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    bd70964 View commit details
    Browse the repository at this point in the history

  50. Avoid size when table is passed

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    b2d8542 View commit details
    Browse the repository at this point in the history

  51. Automatically flatten y if needed

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    a8baf7b View commit details
    Browse the repository at this point in the history

  52. Generate MLJ docstrings

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    d417ef0 View commit details
    Browse the repository at this point in the history

  53. Document selection_method

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    79ba7a6 View commit details
    Browse the repository at this point in the history

  54. Fix deprecated description parameter 

    Co-authored-by: Okon Samuel <39421418+OkonSamuel@users.noreply.github.com>
    @MilesCranmer @OkonSamuel
    MilesCranmer and OkonSamuel committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    09fb9b5 View commit details
    Browse the repository at this point in the history

  55. Store schema in fitresult for consistent output

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    db5be13 View commit details
    Browse the repository at this point in the history

  56. Missing schema return value

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    ad88b44 View commit details
    Browse the repository at this point in the history

  57. Revert storage of schema in fitresult

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    b20270d View commit details
    Browse the repository at this point in the history

  58. Always validate variable names

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    6bc8bc4 View commit details
    Browse the repository at this point in the history

  59. Correct behavior for multitarget output

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3fbb4c3 View commit details
    Browse the repository at this point in the history

  60. Add detailed docstrings for MLJ interface

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    dc6533e View commit details
    Browse the repository at this point in the history

  61. Give example of printing equations in example

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    e8a8398 View commit details
    Browse the repository at this point in the history

  62. Fix incorrect string interpolation

    @MilesCranmer
    MilesCranmer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    2d9cc48 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Add Report section to docstrings

    @MilesCranmer
    MilesCranmer committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c2a6c1f View commit details
    Browse the repository at this point in the history

  2. Make sample weights work for MultitargetSRRegressor

    @MilesCranmer
    MilesCranmer committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    66382d7 View commit details
    Browse the repository at this point in the history

  3. Fix PySR compatibility in Options constructor

    @MilesCranmer
    MilesCranmer committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0fdcb56 View commit details
    Browse the repository at this point in the history

  4. Bump version with MLJ integration

    @MilesCranmer
    MilesCranmer committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    be60f13 View commit details
    Browse the repository at this point in the history