Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for DynamicExpressions to 0.12, (keep existing compat) #242

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 3, 2023

This pull request changes the compat entry for the DynamicExpressions package from 0.11 to 0.11, 0.12.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@MilesCranmer MilesCranmer force-pushed the compathelper/new_version/2023-08-03-00-10-41-276-02712932546 branch from 5c499d5 to 27b9885 Compare August 3, 2023 00:10
@github-actions
Copy link
Contributor Author

github-actions bot commented Aug 3, 2023

Benchmark Results

master 65ec59e... t[master]/t[65ec59e...]
search/multithreading 56.1 ± 3.1 s 56.3 ± 3.9 s 0.997
search/serial 55.7 ± 1.7 s 56.1 ± 1.4 s 0.993
time_to_load 2.26 ± 0.00091 s 2.26 ± 0.0017 s 0.999
utils/best_of_sample 1.1 ± 0.4 μs 1.3 ± 0.4 μs 0.846
utils/check_constraints_x10 18.4 ± 4.5 μs 18.7 ± 4.5 μs 0.984
utils/compute_complexity_x10/Float64 3.5 ± 0.2 μs 3.4 ± 0.2 μs 1.03
utils/compute_complexity_x10/Int64 3.6 ± 0.1 μs 3.6 ± 0.2 μs 1
utils/compute_complexity_x10/nothing 2.4 ± 0.1 μs 2.5 ± 0.2 μs 0.96
utils/optimize_constants_x10 0.045 ± 0.0092 s 0.0444 ± 0.0096 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer MilesCranmer merged commit c75c06a into master Aug 6, 2023
18 checks passed
@MilesCranmer MilesCranmer deleted the compathelper/new_version/2023-08-03-00-10-41-276-02712932546 branch August 6, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant