Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for DynamicExpressions to 0.13, (keep existing compat) #250

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the DynamicExpressions package from ^0.12.2 to ^0.12.2, 0.13.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@MilesCranmer MilesCranmer force-pushed the compathelper/new_version/2023-08-13-00-09-51-898-02805015092 branch from 9a22d3d to ff59af4 Compare August 13, 2023 00:09
@github-actions
Copy link
Contributor Author

Benchmark Results

master ff59af4... t[master]/t[ff59af4...]
search/multithreading 51.9 ± 4.8 s 53 ± 2.9 s 0.978
search/serial 52.7 ± 1.2 s 52.8 ± 0.73 s 0.999
time_to_load 2.19 ± 0.012 s 2.19 ± 0.0087 s 0.998
utils/best_of_sample 1.1 ± 0.4 μs 1 ± 0.3 μs 1.1
utils/check_constraints_x10 18.2 ± 4.5 μs 18.8 ± 4.9 μs 0.968
utils/compute_complexity_x10/Float64 3.4 ± 0.2 μs 3.3 ± 0.2 μs 1.03
utils/compute_complexity_x10/Int64 3.5 ± 0.1 μs 3.4 ± 0.2 μs 1.03
utils/compute_complexity_x10/nothing 2.4 ± 0.2 μs 2.5 ± 0.1 μs 0.96
utils/optimize_constants_x10 0.0428 ± 0.0098 s 0.0443 ± 0.009 s 0.967

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer MilesCranmer merged commit b92ed24 into master Aug 13, 2023
17 checks passed
@MilesCranmer MilesCranmer deleted the compathelper/new_version/2023-08-13-00-09-51-898-02805015092 branch August 13, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant