Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused Tricks dependency #309

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Conversation

MilesCranmer
Copy link
Owner

No longer needed on Julia 1.10+

Copy link
Contributor

Benchmark Results

master 4acd63e... master/4acd63e167b976...
search/multithreading 20.1 ± 0.41 s 17.7 ± 0.3 s 1.14
search/serial 33 ± 0.16 s 33.2 ± 0.25 s 0.994
utils/best_of_sample 0.892 ± 0.33 μs 0.861 ± 0.26 μs 1.04
utils/check_constraints_x10 11.7 ± 3 μs 11.6 ± 3 μs 1.01
utils/compute_complexity_x10/Float64 2.21 ± 0.12 μs 2.21 ± 0.12 μs 1
utils/compute_complexity_x10/Int64 2.22 ± 0.12 μs 2.16 ± 0.11 μs 1.03
utils/compute_complexity_x10/nothing 1.49 ± 0.1 μs 1.45 ± 0.099 μs 1.03
utils/optimize_constants_x10 31.6 ± 6.5 ms 30.4 ± 6.3 ms 1.04
time_to_load 0.901 ± 0.017 s 0.881 ± 0.01 s 1.02

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer MilesCranmer merged commit 830e809 into master Apr 27, 2024
25 checks passed
@MilesCranmer MilesCranmer deleted the remove-tricks branch April 27, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant