Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to floating ui in plugin tooltip #1373

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

Saul-Mirone
Copy link
Member

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Migrate the tippy package to floating ui in plugin-tooltip

How did you test this change?

CI and manully

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 1:37am

Copy link

nx-cloud bot commented Jun 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 37c2081. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link

cypress bot commented Jun 11, 2024

Passing run #878 ↗︎

0 83 0 0 Flakiness 0

Details:

Merge 37c2081 into 8e95bfe...
Project: Default Project Commit: b01ec6bedf ℹ️
Status: Passed Duration: 01:48 💡
Started: Jun 11, 2024 1:43 AM Ended: Jun 11, 2024 1:44 AM

Review all test suite changes for PR #1373 ↗︎

@Saul-Mirone Saul-Mirone merged commit e4e4a75 into main Jun 11, 2024
14 checks passed
@Saul-Mirone Saul-Mirone deleted the migrate-to-floating-ui-in-tooltip branch June 11, 2024 02:33
Copy link

cypress bot commented Jun 11, 2024

Passing run #879 ↗︎

0 83 0 0 Flakiness 0

Details:

feat: migrate to floating ui in plugin tooltip (#1373)
Project: Default Project Commit: e4e4a7576f
Status: Passed Duration: 01:45 💡
Started: Jun 11, 2024 2:36 AM Ended: Jun 11, 2024 2:38 AM

Review all test suite changes for PR #1373 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant