Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate tippy to floating ui in plugin slash #1375

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

Saul-Mirone
Copy link
Member

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Migrate tippy in slash plugin to @flating-ui/dom

How did you test this change?

CI & Manually

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 1:14pm

Copy link

nx-cloud bot commented Jun 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e7ab616. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link

cypress bot commented Jun 12, 2024

Passing run #882 ↗︎

0 83 0 0 Flakiness 0

Details:

Merge e7ab616 into 4e14691...
Project: Default Project Commit: aac3ed18d3 ℹ️
Status: Passed Duration: 02:20 💡
Started: Jun 12, 2024 1:17 PM Ended: Jun 12, 2024 1:20 PM

Review all test suite changes for PR #1375 ↗︎

@Saul-Mirone Saul-Mirone merged commit a7ce1a9 into main Jun 12, 2024
14 checks passed
@Saul-Mirone Saul-Mirone deleted the migrate-tippy-in-slash branch June 12, 2024 13:20
Copy link

cypress bot commented Jun 12, 2024

Passing run #883 ↗︎

0 83 0 0 Flakiness 0

Details:

feat: migrate tippy to floating ui in plugin slash (#1375)
Project: Default Project Commit: a7ce1a9a48
Status: Passed Duration: 01:50 💡
Started: Jun 12, 2024 1:24 PM Ended: Jun 12, 2024 1:26 PM

Review all test suite changes for PR #1375 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant