Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ppx_deriving_yojson to upstream #10952

Closed
2 of 9 tasks
Firobe opened this issue May 13, 2022 · 3 comments
Closed
2 of 9 tasks

Upgrade ppx_deriving_yojson to upstream #10952

Firobe opened this issue May 13, 2022 · 3 comments
Assignees
@Firobe

Comments

@Firobe
Copy link
Contributor

Firobe commented May 13, 2022 •
edited

It appears that ppx_deriving_yojson is pinned to a local version because some changes were needed. These changes are now upstreamed, and we can get rid of the submodule.

We can also remove ppxfind from the switch, which was only used as a dependency here.

  • Unpin
  • Upgrade
  • Check build consistency
  • Add to switch
  • Remove ppxfind from switch
  • Remove from pin script
  • Remove submodule
  • Merge
  • Suggest deletion/archival of the pin repository

Needed for #10940
@Firobe Firobe self-assigned this May 13, 2022
@Firobe Firobe added the Tweag label May 13, 2022
@Firobe
Copy link
Contributor Author

Firobe commented May 25, 2022

To properly do this, we need to upgrade ppxlib itself to the next version. This entails some changes in ppxs across the codebase.

@Firobe
Copy link
Contributor Author

Firobe commented May 25, 2022

Actually #10940 will need an upgrade to the latest ppxlib version. So we first need to deal with graphql_ppx #11081

@Firobe
Copy link
Contributor Author

Firobe commented May 27, 2022

This issue is now subsumed by #11081 (see PR #11114)

@Firobe Firobe closed this as completed May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Firobe Firobe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Firobe