Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade graphql_ppx to use ppxlib #11081

Closed
Firobe opened this issue May 25, 2022 · 3 comments · Fixed by #11114 or #11159
Closed

Upgrade graphql_ppx to use ppxlib #11081

Firobe opened this issue May 25, 2022 · 3 comments · Fixed by #11114 or #11159
Assignees
@Firobe

Comments

@Firobe
Copy link
Contributor

Firobe commented May 25, 2022 •
edited
Loading

graphql_ppx currently uses ppx_tools_versioned, which is slowly rotting, instead of the now-standard ppxlib. In turn, this means we need ocaml-migrate-parsetree, which blocks ant upgrade of ppxlib, itself needed for OCaml upgrades (see #10940).

The latest upstream versions of graphql_ppx use ppxlib, but are targeted at Reason instead of OCaml, so we cannot use them.

Two alternatives:

  • find an upstream version which still targets OCaml and uses ppxlib, if it exists
  • re-engineer the current custom graphql_ppx so it uses latest ppxlib
@Firobe Firobe added the Tweag label May 25, 2022
@Firobe Firobe self-assigned this May 25, 2022
@Firobe Firobe mentioned this issue May 25, 2022
Closed
9 tasks
@Firobe
Copy link
Contributor Author

Firobe commented May 25, 2022

Actually the latest version of graphql_ppx can be used perfectly with OCaml. The reason it has not been upgraded thus far is that is was rewritten in ReasonML. However recently everything has been rewritten back to OCaml, so we should consider using latest upstream graphql_ppx.

This was referenced May 25, 2022
Closed
Merged
Merged
@Firobe
Copy link
Contributor Author

Firobe commented May 27, 2022

Detailed work in progress in #11114

@Firobe
Copy link
Contributor Author

Firobe commented Jun 1, 2022

The work on compatible is now awaiting review

@Firobe Firobe linked a pull request Jun 2, 2022 that will close this issue
Use upstream graphql_ppx, upgrade ppxlib (DEVELOP) #11159
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Firobe Firobe

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Firobe and others