Add execution timing metrics for participation code #10158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nholland94
added
the
ci-build-me
nholland94
requested review from
bkase,
imeckler,
mrmr1993,
psteckler and
a team
as code owners
nholland94
force-pushed
the
feature/validation-timing-metrics
branch
7 times, most recently
from
c2fdc8b
to
9cce464
Compare
nholland94
force-pushed
the
feature/validation-timing-metrics
branch
3 times, most recently
from
6815c58
to
ee10edf
Compare
nholland94
force-pushed
the
feature/validation-timing-metrics
branch
from
ee10edf
to
2b746ee
Compare
nholland94
changed the title
nholland94
added
ci-build-me
mrmr1993
approved these changes
Mar 17, 2022
| @@ -2276,39 +2276,59 @@ let hash_transaction = | |||
| in | |||
| printf "%s\n" (Transaction_hash.to_base58_check hash)) | |||
|
|
|||
| let humanize_graphql_error | |||
| @@ -654,7 +660,8 @@ end = struct | |||
| t.next_flush <- | |||
| Some | |||
| (Clock.Event.run_after max_wait | |||
| (fun () -> | |||
| (* <-- TODO: pretty sure this is a bug (this can infinitely delay flushes *) | |||
There was a problem hiding this comment.
Yea, looks like there should be an explicit
(if not (Strict_pipe.Writer.is_closed t.flush_w) then
Strict_pipe.Writer.write t.flush_w () );after the Option.iter. Doesn't need fixing in this PR though.
psteckler
reviewed
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.