Integration test and gating config fixes #10188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeee
added
the
ci-build-me
georgeee
force-pushed
the
georgeee/fix-testnet-bootstrapping-issue
branch
from
c5e302d
to
1973a61
Compare
georgeee
requested review from
bkase,
psteckler,
imeckler and
mrmr1993
as code owners
georgeee
force-pushed
the
georgeee/fix-testnet-bootstrapping-issue
branch
5 times, most recently
from
294a4f8
to
53ed907
Compare
georgeee
removed
the
ci-build-me
georgeee
force-pushed
the
georgeee/fix-testnet-bootstrapping-issue
branch
2 times, most recently
from
7014f21
to
4d31043
Compare
nholland94
force-pushed
the
georgeee/fix-testnet-bootstrapping-issue
branch
from
4d31043
to
cec08fb
Compare
nholland94
approved these changes
Feb 22, 2022
QuiteStochastic
added
the
ci-build-me
nholland94
changed the title
lk86
approved these changes
Feb 23, 2022
nholland94
force-pushed
the
georgeee/fix-testnet-bootstrapping-issue
branch
from
16e3e0d
to
7515d1b
Compare
This reverts commit 4af19fc. Peers reliability test was switched off temorarily because of flakiness.
Problem: known private address set is overwritten when gating config is set. Solution: do not overwrite known private addresses.
Problem: when a connection is refused, reason for refusal is not printed which complicates debugging of such occasions. Solution: rewrite connection gating logic to keep reason of accepting/denying of connection and print it.
Problem: when logging is configured for the libp2p helper executable, errors are ignored. Solution: log errors of logging configuration.
Problem: log level was set for an absent logger. Solution: remove the faulty line.
Problem: legacy implementation of mDNS service is used, although there is no obstacle to using a newer implementation. Solution: use newer implementation.
Problem: test is using a wrong (potentionally faulty) logic for taking timeouts into account. Solution: refactor MDNS test.
Problem: a deprecated env variable is declared in the helm chart. Solution: remove unused env variable.
Problem: in k8s context mdns support is fragile and may sometimes be an obstacle in running integration tests. Solution: whitelist ip nets from MINA_CLIENT_TRUSTLIST as known private ip subnets. This would ensure peers won't be discarded when discovered via routing discovery.
Problem: libp2p_helper tests sometimes timeout without good reason for it. Solution: extend timeout for the test to 25 minutes.
Problem: quckicheck tests finished with "fatal error: concurrent map read and map write". Solution: remove unsupervised concurrent access that triggered the fatal error.
Problem: in some cases, integration tests report to pass when they actually exited with an error. Solution: report an error to CI so that test is marked a failure.
georgeee
force-pushed
the
georgeee/fix-testnet-bootstrapping-issue
branch
from
03857aa
to
e650746
Compare
georgeee
force-pushed
the
georgeee/fix-testnet-bootstrapping-issue
branch
from
e650746
to
c28464a
Compare
georgeee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same fix as #10229 and #10276. So many PRs were created due branch compatibility issues.
This PR:
Most fixes are result of the investigation into why is peers reliability test failing. This investigation revealed that mDNS discovery upon which the test relied stopped working in kubernetes cluster after recent change of firewall policy. Change in firewall policy can not be reverted as it was dictated by some security concerns. This PR implements an alternative solution: it allows to connect to peers from the
10.0.0.0/8network even when they are not discovered through mDNS.Explain how you tested your changes:
Existing tests provide a good coverage.
Checklist: