Fix snark worker support in integration tests #10279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeee
added
the
ci-build-me
| @@ -32,10 +32,14 @@ spec: | |||
| image: {{ $.Values.mina.image }} | |||
| {{ if $.Values.mina.useCustomEntrypoint -}} | |||
| command: [{{ $.Values.mina.customEntrypoint }}] | |||
| {{- else }} | |||
There was a problem hiding this comment.
Would this work for non-integration-test deployments as well? cc @QuiteStochastic
There was a problem hiding this comment.
i THINK george's change should be fine. the default daemon entrypoint is more or less just mina $INPUT_ARGS $EXTRA_FLAGS 2>mina-stderr.log 1>mina.log &. so if there is no command, then args will be passed straight to that. cc @lk86
QuiteStochastic
force-pushed
the
georgeee/fix-snark-worker-intg-test
branch
2 times, most recently
from
d42c364
to
acc5483
Compare
This was referenced Feb 28, 2022
georgeee
force-pushed
the
georgeee/fix-snark-worker-intg-test
branch
from
90216e2
to
3440a4d
Compare
georgeee
force-pushed
the
georgeee/fix-snark-worker-intg-test
branch
from
3440a4d
to
4231466
Compare
QuiteStochastic
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test framework supports snark workers by design. This functionality wasn't used and well-maintained. This PR brings it up-to-date, read to be used.
Checklist: