Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter command ids in SQL #10312

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Filter command ids in SQL #10312

merged 4 commits into from
Mar 29, 2022

Conversation

psteckler
Copy link
Member

In replayer, filter user and internal command ids by the start slot, instead of doing the filtering in OCaml on the commands referred-to by those ids.

This strategy saves a bit of shared memory for Postgresql, presumably because it doesn't have to load so much data.

@psteckler psteckler added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Feb 28, 2022
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this will be more efficient!

@mrmr1993 mrmr1993 merged commit babe7ff into compatible Mar 29, 2022
@mrmr1993 mrmr1993 deleted the fix/filter-cmd-ids-in-sql branch March 29, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants