Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump soft_timeout of Wait_condition.blocks_to_be_produced in integration tests #10326

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Mar 2, 2022

This PR increases the soft-timeout used when waiting for some number of blocks to be produced. To quote the new comment in the code:

      (* We add 1 here to make sure that we see the entirety of at least 2*n
         full slots, since slot time may be misaligned with wait times after
         non-block-related waits.
         This ensures that low numbers of blocks (e.g. 1 or 2) have a
         reasonable probability of success, reducing flakiness of the tests.
      *)

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Mar 2, 2022
@mrmr1993 mrmr1993 requested a review from a team as a code owner March 2, 2022 02:45
@QuiteStochastic
Copy link
Contributor

looks good, just make sure this gets merged to compatible as well

@mrmr1993
Copy link
Member Author

mrmr1993 commented Mar 2, 2022

looks good, just make sure this gets merged to compatible as well

good catch, I'll redirect this at compatible and merge on up from there

@mrmr1993 mrmr1993 changed the base branch from develop to compatible March 2, 2022 02:56
@mrmr1993 mrmr1993 requested review from a team, bkase and imeckler as code owners March 2, 2022 02:56
@mrmr1993 mrmr1993 force-pushed the feature/integration-test-wait-an-extra-slot branch from 0e4889f to dadae4d Compare March 2, 2022 02:57
@mrmr1993 mrmr1993 merged commit 6badc1d into compatible Mar 2, 2022
@mrmr1993 mrmr1993 deleted the feature/integration-test-wait-an-extra-slot branch March 2, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants