Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry failed unit tests using dune cache #10441

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Mar 8, 2022

This PR tweaks the unit test runner script, so that it will retry the tests once within the same buildkite run. This allows any flaking test to be re-run without a rebuild, and without running the other tests that have already succeeded.

If the test still fails, either due to a badly configured/misbehaving buildkite node or a genuine error in the PR, then the normal buildkite retry process will still take effect.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Mar 8, 2022
@mrmr1993 mrmr1993 requested a review from a team as a code owner March 8, 2022 21:22
@mrmr1993 mrmr1993 merged commit 55f2bf3 into compatible Mar 8, 2022
@mrmr1993 mrmr1993 deleted the feature/retry-failed-unit-tests branch March 8, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants