[nix prep] trace-tool: use newer cargo version, update Cargo.lock #10568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmr1993
approved these changes
Mar 23, 2022
yorickvP
added
the
ci-build-me
lk86
approved these changes
Apr 11, 2022
buildkite/src/Jobs/Lint/Rust.dhall
Outdated
| @@ -24,7 +24,7 @@ Pipeline.build | |||
| steps = [ | |||
| Command.build | |||
| Command.Config::{ | |||
| commands = [ Cmd.runInDocker jobDocker "cd src/app/trace-tool ; cargo check --frozen" ] | |||
| commands = RunInToolchain.runInToolchainBuster ([] : List Text) "cd src/app/trace-tool ; PATH=/home/opam/.cargo/bin:$PATH cargo check" | |||
There was a problem hiding this comment.
Can you use runInToolchainBullseye ? I have a PR in flight that will make bullseye the default everywhere so this would better set up for that work
| @@ -24,7 +25,7 @@ Pipeline.build | |||
| steps = [ | |||
| Command.build | |||
| Command.Config::{ | |||
| commands = [ Cmd.runInDocker jobDocker "cd src/app/trace-tool && cargo build --frozen" ] | |||
| commands = RunInToolchain.runInToolchainBuster ([] : List Text) "cd src/app/trace-tool && PATH=/home/opam/.cargo/bin:$PATH cargo build" | |||
There was a problem hiding this comment.
Same here, runInToolchainBullseye would be preferable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trace-tool was built using outdated rustToolchain, even though newer
versions of cargo/rustc are already part of the main Mina
toolchain. Use the main toolchain to build trace-tool, and update
Cargo.lock format to the newer version.