[nix prep] mina_version/gen.sh: make version info generation more reselient and flexible #10569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balsoft
force-pushed
the
mina-gen-version-fixes
branch
from
944b3b1
to
bd6611f
Compare
mrmr1993
approved these changes
Mar 23, 2022
mrmr1993
added
the
ci-build-me
|
@balsoft can you create a version of this against develop with the merge conflicts fiexd? It should be enough to git checkout mina-gen-version-fixes -b mina-gen-version-fixes-develop
git merge origin/develop
# fix merge conflicts
git commit
git push origin HEADand then create a PR pointing at develop. |
|
There's already such a PR, #10620 |
🤦♂️ Thanks, so there is! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the version info generation more flexible (by allowing to
override various information with env variables) and reselient (by
allowing
gitto not be present in PATH).