Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lk86/change cronjob granularity 10min #10581

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

lk86
Copy link
Contributor

@lk86 lk86 commented Mar 23, 2022

To ensure that all backups to GCP buckets complete in-time and result with the correct filename at midnight (but to still allow manual runs at other times of day), this PR rewrites the datestamp in our cronjobs to always end in 0. This means if a job starts running at midnight (00:00) but does not complete successfully until 00:01 or up to 9 minutes past the hour, the timestamp will still read 00:00.

…inutes to make sure more jobs create artifacts with _0000 timestamps
@lk86 lk86 requested a review from stevenplatt March 23, 2022 01:36
Copy link
Contributor

@stevenplatt stevenplatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved; no conflicts or concerns that i can see.

@lk86 lk86 merged commit c4e4038 into compatible Mar 23, 2022
@lk86 lk86 deleted the lk86/change-cronjob-granularity-10min branch March 23, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants