Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildkite: skip git env upload step #10582

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

balsoft
Copy link
Contributor

@balsoft balsoft commented Mar 23, 2022

"Upload Git Env" step is meaningless now that Mina is a monorepo. Get rid of it.

@balsoft balsoft requested a review from a team as a code owner March 23, 2022 08:32
@balsoft balsoft added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Mar 23, 2022
@balsoft balsoft force-pushed the buildkite-skip-git-env-upload branch from 48b96f4 to 445d4a5 Compare March 23, 2022 09:15
@balsoft balsoft force-pushed the buildkite-skip-git-env-upload branch from 445d4a5 to e8a1634 Compare March 23, 2022 11:46
Copy link
Contributor

@lk86 lk86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I knew this was possible when i first switched this over to using a script for the environment but I never got around to removing it properly, thank you! @bkase please review the change to your dhall library, i'm not confident there

@balsoft balsoft merged commit 4475046 into compatible Mar 25, 2022
@balsoft balsoft deleted the buildkite-skip-git-env-upload branch March 25, 2022 09:28
@robinbb robinbb added the Tweag label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants