Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests: don't wait 30s before every GraphQL test #10614

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Integration tests: don't wait 30s before every GraphQL test #10614

merged 1 commit into from
Mar 25, 2022

Conversation

mrmr1993
Copy link
Member

We currently spend 30s waiting before sending each GraphQL request in integration tests. This PR removes that wait, since it should almost never be necessary.

For tests where we send a lot of transactions, this can add up quickly. For example, in the snapps integration test, we spend at least 6 minutes in these 30s sleeps!

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Mar 24, 2022
@mrmr1993 mrmr1993 requested a review from a team as a code owner March 24, 2022 20:30
@mrmr1993 mrmr1993 added ci-build-me Add this label to trigger a circle+buildkite build for this branch and removed ci-build-me Add this label to trigger a circle+buildkite build for this branch labels Mar 24, 2022
@mrmr1993 mrmr1993 merged commit 8f618d2 into compatible Mar 25, 2022
@mrmr1993 mrmr1993 deleted the feature/dont-wait-30s-for-graphql branch March 25, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuiteStochastic QuiteStochastic QuiteStochastic approved these changes

@nholland94 nholland94 nholland94 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrmr1993 @QuiteStochastic @nholland94