Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildkite: remove "optional" from job names #10680

Merged
merged 1 commit into from
May 17, 2022
Merged

buildkite: remove "optional" from job names #10680

merged 1 commit into from
May 17, 2022

Conversation

balsoft
Copy link
Contributor

@balsoft balsoft commented Apr 1, 2022

Jobs currently named "optional" are in fact mandatory. Remove
confusing naming.

@balsoft balsoft requested a review from a team as a code owner April 1, 2022 20:18
@balsoft balsoft added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Apr 11, 2022
@balsoft
buildkite: remove "optional" from job names
1c98398 
Jobs currently named "optional" are in fact mandatory. Remove
confusing naming.
@lk86 lk86 mentioned this pull request May 4, 2022
Closed
1 task
stevenplatt
stevenplatt approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@stevenplatt stevenplatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. CI completes cleanly, and this item does not conflict with other changes I am aware of.

@balsoft balsoft merged commit e8a524e into compatible May 17, 2022
@balsoft balsoft deleted the rename-optional-steps branch May 17, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@stevenplatt stevenplatt stevenplatt approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balsoft @mrmr1993 @stevenplatt @joseandro