Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove validation_callback out of block type #10684

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Remove validation_callback out of block type #10684

merged 2 commits into from
Apr 7, 2022

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Apr 3, 2022 •
edited
Loading

Problem: mutable field validation_callback is misplaced in the external
transition type.

Solution: remove the field out of the block type.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@georgeee georgeee requested a review from a team as a code owner April 3, 2022 14:18
@georgeee georgeee added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Apr 3, 2022
@georgeee
Remove validation_callback out of block type
cb6ca59 
Problem: mutable field validation_callback is misplaced in the external
transition type.

Solution: remove the field out of the block type.
@georgeee georgeee force-pushed the georgeee/remove-valid-callback-out-of-block branch from efcc29a to cb6ca59 Compare April 6, 2022 14:54
@georgeee
Return validation_callback to raw version type
028b4fe 
Problem: binary representation became incompatible

Solution: maintain a stub
@georgeee georgeee force-pushed the georgeee/remove-valid-callback-out-of-block branch from 93a7bbd to 028b4fe Compare April 6, 2022 15:54
@georgeee georgeee mentioned this pull request Apr 6, 2022
Merged
6 tasks
@nholland94 nholland94 merged commit 08a8163 into compatible Apr 7, 2022
@nholland94 nholland94 deleted the georgeee/remove-valid-callback-out-of-block branch April 7, 2022 14:39
@nholland94 nholland94 mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nholland94 nholland94 nholland94 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@georgeee @nholland94