Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deb s3 atomic upload compatible #10733

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Deb s3 atomic upload compatible #10733

merged 2 commits into from
Apr 21, 2022

Conversation

Firobe
Copy link
Contributor

@Firobe Firobe commented Apr 11, 2022

Companion PR for #10719. No difference

@Firobe
Package upload more atomic
c5a78f6 
During package uploads, packages are now uploaded as temporary filenames
and then moved to their final names in bulk.

This prevents:
1. corrupted files with visible paths if the transfer is interrupted
2. a user downloading a corrupted file while it is being transferred

Ultimately, this improves (but cannot completely fix) the possibility of
race conditions between deb-s3 and other jobs downloading from the
repository.

Manifests are uploaded as before, since they have to be uploaded as soon
as possible, before the lock is released.
@Firobe Firobe requested review from a team as code owners April 11, 2022 17:27
@Firobe Firobe changed the base branch from develop to compatible April 11, 2022 17:29
@Firobe Firobe added ci-build-me Add this label to trigger a circle+buildkite build for this branch Tweag labels Apr 11, 2022
@Firobe Firobe self-assigned this Apr 11, 2022
@Firobe Firobe requested a review from lk86 April 11, 2022 17:36
lk86
lk86 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@lk86 lk86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but still needs the toolchain images updated. Merging the develop PR first might hurt you here but I can help you cross that bridge once you're blocked on "merges cleanly"

@Firobe
Copy link
Contributor Author

Firobe commented Apr 11, 2022 •
edited
Loading

@lk86 I am now blocked on exactly what you mentioned ;)
I am not clear how not merging the other PR would've helped since there was different conflicts before merging it. What is the usual best path you go through?

This was referenced Apr 20, 2022
Merged
Closed
@Firobe
Copy link
Contributor Author

Firobe commented Apr 21, 2022

Conflicts are resolved, merging now.

@Firobe Firobe merged commit bd102a2 into compatible Apr 21, 2022
@Firobe Firobe deleted the deb-s3-atomic-upload_COMPATIBLE branch April 21, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lk86 lk86 lk86 approved these changes

Assignees

@Firobe Firobe

Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Firobe @lk86