Use LLD as a linker #10762
Merged
Use LLD as a linker #10762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firobe
added
the
ci-build-me
Firobe
force-pushed
the
feature/link-with-lld
branch
from
0f30757
to
cc79fc0
Compare
|
CI seems to pass except for merging into develop due to changed container images |
Firobe
requested review from
bkase,
psteckler,
imeckler,
mrmr1993 and
a team
as code owners
psteckler
approved these changes
Apr 19, 2022
lk86
approved these changes
Apr 21, 2022
Firobe
force-pushed
the
feature/link-with-lld
branch
from
cc79fc0
to
f016f2d
Compare
Firobe
force-pushed
the
feature/link-with-lld
branch
from
f016f2d
to
3477c19
Compare
|
Ready to merge when #10768 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis in #10503 has shown that switching from the GNU linker to LLVM's lld improves build times, especially when building incrementally (where linking is a significant bottleneck).
This PR makes that change by:
lldto the toolchainlldocaml-rocksdbso that it correctly links withlld, which is more strict than the GNU linker with respect to duplicate symbolsCloses #10761