Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix catchup double cache invalidation #10769

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Fix catchup double cache invalidation #10769

merged 2 commits into from
Apr 27, 2022

Conversation

nholland94
Copy link
Member

No description provided.

@nholland94 nholland94 requested a review from a team as a code owner April 21, 2022 18:35
@nholland94 nholland94 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Apr 21, 2022
mrmr1993
mrmr1993 approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It's not clear to me that this fixes the specific bug we were investigating, but it definitely fixes a bug!

We discussed elsewhere that there are other race conditions; we should fix those in a (series of) follow-up(s).

@nholland94 nholland94 merged commit a058051 into compatible Apr 27, 2022
@nholland94 nholland94 deleted the fix/catchup-double-cache-invalidation branch April 27, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nholland94 @mrmr1993