Extract validation out of External_transition #10780
Conversation
georgeee
added
the
ci-build-me
| * 'staged_ledger_diff | ||
| * 'protocol_versions | ||
|
|
||
| (* TODO commented out because of weird type errors *) |
There was a problem hiding this comment.
After discussing with you are reviewing, I think it is fine to just delete these constraints altogether.
| in | ||
| validated_transition | ||
| (* TODO: the delta transition chain proof is incorrect (same behavior the daemon used to have, but we should probably fix this?) *) |
There was a problem hiding this comment.
Let's log an issue to review this. It's fine to merge as is, but we should review this because it could be hiding a subtle bug (if we serve these proofs to bootstrapping nodes or something).
…t-validated-out-of-external-transition
georgeee
requested review from
bkase,
psteckler,
imeckler,
mrmr1993 and
a team
as code owners
…t-validated-out-of-external-transition
georgeee
force-pushed
the
georgeee/extract-validated-out-of-external-transition
branch
from
ffe4d1a
to
3839ef9
Compare
…t-validated-out-of-external-transition
georgeee
force-pushed
the
georgeee/extract-validated-out-of-external-transition
branch
from
af76a6a
to
2f4f657
Compare
georgeee
force-pushed
the
georgeee/extract-validated-out-of-external-transition
branch
from
a19ddec
to
192d567
Compare
…t-validated-out-of-external-transition
| @@ -82,7 +82,7 @@ let g:syntastic_ocaml_checkers=['merlin'] | |||
| - Now `/usr/bin/opam install merlin ocp-indent core async ppx_jane ppx_deriving` (everything we depend on, that you want autocompletes for) for doc reasons | |||
| - Make sure you have `au FileType ocaml set omnifunc=merlin#Complete` in your vimrc | |||
| - Install an auto-completer (such as YouCompleteMe) and a syntastic (such syntastic or ALE) | |||
| - If you use vscode, you might like these extensions | |||
| - If you use vscode, you might like this extension | |||
There was a problem hiding this comment.
It should be these extensions, right?
There was a problem hiding this comment.
Oh yeah, this is an accidental change. I will fix it as a separate micro-PR
| let b1 = Transition_frontier.Breadcrumb.validated_transition br1 in | ||
| let b2 = Transition_frontier.Breadcrumb.validated_transition br2 in | ||
| (* We force evaluation of state body hash for both blocks for further equality check *) | ||
| let _hash1 = Mina_block.Validated.state_body_hash b1 in |
There was a problem hiding this comment.
I'm not sure if I follow the necessity of this. If the state body hashes are equal, that implies that the state body hashes are equal, even if we don't have those values cached.
There was a problem hiding this comment.
State body hash is stored in a mutable variable which is set once the value is actually calculated.
There was a problem hiding this comment.
The problem arises when we compare this field for blocks computed in different code paths: one might have mutable variable set to None (because state body hash was not ever calculated up until the moment of execution of the line) and the other is Some x. Hence I force that both state hashes are evaluated and equal to Some x.
nholland94
deleted the
georgeee/extract-validated-out-of-external-transition
branch
Refactoring that further reorganizes
External_transitionmodule and associated typesExplain your changes:
ValidatedandValidationsubmodules out ofExternal_transitionExplain how you tested your changes: no functionality is touched, existing tests will cover it well.
Checklist: