Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit genesis configs #10785

Merged
merged 5 commits into from
Apr 30, 2022
Merged

Explicit genesis configs #10785

merged 5 commits into from
Apr 30, 2022

Conversation

QuiteStochastic
Copy link
Contributor

explicitly as many of the runtime_configs, so that they can be tweaked by tests

@QuiteStochastic QuiteStochastic requested a review from a team as a code owner April 27, 2022 15:34
@QuiteStochastic QuiteStochastic changed the base branch from develop to compatible April 27, 2022 15:35
@QuiteStochastic QuiteStochastic added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Apr 27, 2022
Copy link
Member

@deepthiskumar deepthiskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Commented how I got 12 for the number of payments required

Network.Node.must_get_account_data ~logger timed_node_c
~public_key:sender_pub_key
let%bind () =
(* deepthi says that to fill up a `small` transaction capacity with work delay of 1, there needs to be 12 total txns sent. 2 successfull txn are sent in the prior course of this test, so spamming out at least 10 more here will trigger a ledger proof to be emitted *)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Max number trees in the scan state is `(transaction_capacity_log+1) * (work_delay+1)` and for 2^2 transaction capacity and work delay 1 it is `(2+1)*(1+1)=6`. Per block there can be 2 transactions included (other two slots would be for a coinbase and fee transfers). In the initial state of the network, the scan state waits till all the trees are filled before emitting a proof from the first tree. Hence, 6*2 transactions till we get the first snarked ledger.

Also, could you wrap the comment at 80chars?

@QuiteStochastic QuiteStochastic merged commit 6e281d9 into compatible Apr 30, 2022
@QuiteStochastic QuiteStochastic deleted the explicit_genesis_configs branch April 30, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants