Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious "Using password from environment variable" logs at startup #10865

Merged
merged 2 commits into from
May 6, 2022

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented May 5, 2022

This PR fixes #10863 by delaying printing of Using password from environment variable until the commands that should print it are actually run.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label May 5, 2022
@mrmr1993 mrmr1993 requested a review from a team as a code owner May 5, 2022 18:28
@mrmr1993 mrmr1993 merged commit aca77ed into compatible May 6, 2022
@mrmr1993 mrmr1993 deleted the fix/remove-spurious-log-message branch May 6, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants