Allow reversed fields in Fee_excess JSON #10871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
added
the
ci-build-me
mrmr1993
approved these changes
May 5, 2022
QuiteStochastic
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Snark_work_receivedstructured log inSnark_pool_diffwas causing errors because theworkfield had JSON that could not be parsed. The parse failure was due to a reversal of the fields in the JSON for fee excesses.I was unable to track down where that reversal occurred, perhaps it's something internal in the Yojson library.
Fee_excess.to_yojsonproduces a particular field order, and the only instance I could find where we construct such JSON manually, the fields are in the right order.The solution here is to allow
of_yojsonto accept either order of the fields, per Postel's Law.Closes #10849. Verified that the unparseable JSON mentioned in that issue becomes parseable after this change.