Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatible] Use the archive URL for the current branch when running tests #10876

Merged
merged 1 commit into from
May 6, 2022

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented May 6, 2022

A change to the archive node schema on develop has broken the archive node integration tests on compatible. This PR is a reduced version of the fix applied to develop, which uses the github URL for the current commit instead.

Presumably we will require an equivalent fix on master.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label May 6, 2022
@mrmr1993 mrmr1993 requested a review from a team as a code owner May 6, 2022 12:48
mrmr1993 added a commit that referenced this pull request May 6, 2022
@mrmr1993 mrmr1993 merged commit 416ba61 into compatible May 6, 2022
@mrmr1993 mrmr1993 deleted the feature/update-archive-image branch May 6, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants