Upgrade dune and ocamlformat + reformat files #10896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firobe
added
the
ci-build-me
|
Since the reformat is always a moving target, waiting for approval on both this PR and #10906 before rebasing and solving the conflicts. Also need to update container images for this branch. |
Closed
mitschabaude
approved these changes
May 9, 2022
mrmr1993
approved these changes
May 9, 2022
lk86
approved these changes
May 10, 2022
Upgrade to dune 3.1.1, ocamlformat 20.1 (the two are tied). Also fix incoherences between root and installed in the opam export, and add the useful ocp-browser.
All of the values were set to their default values, so there is no functional change.
Firobe
force-pushed
the
upgrade-dune-ocamlformat
branch
from
9a9a82d
to
36b56c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades dune to version 3.1.1 (see reasons why). A necessary side-effect is upgrading ocamlformat, which unfortunately implies reformatting most files. Most reformatting changes are simply spaces added before closing parentheses.
The current
.ocamlformatis edited by removing deprecated and removed options (which were set to their default values anyway). The file was already as explicit as possible, so the reformatting changes cannot be minimized further.This PR also add the ocp-browser package to the switch, to help easily exploring installed interfaces.
Test:
Closes #10816