Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for local network spinning up script #11105

Merged
merged 2 commits into from
May 27, 2022

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented May 26, 2022

  • The real issue we address here is the way of genesis_state_timestamp updating.
    • Using previous date-time formatting string %Y-%m-%dT%H:%M:%S.%6NZ (time-zone specifically) is not acceptable by Node at least on macOS (on compatible and develop branches).
  • BREAKING CHANGES introduced, hence, targets develop:
    • The ledgerfolder default path was changed in order to preserve work-dir after the OS restart.
  • Everything else is just a usability/cosmetic improvements.
  • The -generate-genesis-proof Daemon's CLI arg was removed since it was deprecated;
  • Fix bug with reset=false option in order to prevent the work-dir cleaning up between scrip restarts.

@shimkiv shimkiv added bug enhancement Not big enough to be a feature, but is a smaller improvement ci-build-me Add this label to trigger a circle+buildkite build for this branch labels May 26, 2022
@shimkiv shimkiv requested review from a team as code owners May 26, 2022 17:58
@shimkiv shimkiv changed the title Improvements for local network spinning up script (Part 2) Improvements for local network spinning up script May 27, 2022
@shimkiv shimkiv merged commit 1d2a111 into compatible May 27, 2022
@shimkiv shimkiv deleted the local-network-script-improvements-part2 branch May 27, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Changes bug ci-build-me Add this label to trigger a circle+buildkite build for this branch enhancement Not big enough to be a feature, but is a smaller improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants