Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steven ledger gen fix #11157

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Steven ledger gen fix #11157

merged 2 commits into from
Jun 2, 2022

Conversation

stevenplatt
Copy link
Contributor

Explain your changes:
This PR is to update the README documentation used for deploying mina testnets using Google Cloud and Terraform infra-as-code. Additionally, this PR fixes a bug that prevented the generate-keys-and-ledger.sh script from properly outputing a testnet ledger.

Explain how you tested your changes:
The change for the ledger gen script has been tested locally by running the generate-key-and-ledger.sh script locally on my machine, using a clean checkout from both develop and compatible to ensue compatibility.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@stevenplatt stevenplatt added planning-for-testnet Issues that should be closed prior to test net launch documentation testnet testnet-bug ci-build-me Add this label to trigger a circle+buildkite build for this branch labels Jun 1, 2022
@stevenplatt stevenplatt requested a review from a team June 1, 2022 22:44
@stevenplatt stevenplatt self-assigned this Jun 1, 2022
@stevenplatt stevenplatt merged commit ece1d7d into compatible Jun 2, 2022
@stevenplatt stevenplatt deleted the steven-ledger-gen-fix branch June 2, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch documentation planning-for-testnet Issues that should be closed prior to test net launch testnet testnet-bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants