Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable whole_program compilation for SnarkyJS #11166

Merged
merged 7 commits into from
Jun 6, 2022

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Jun 3, 2022

This PR tinkers with some dune flags to allow us to compile SnarkyJS in whole_program mode. This reduces the size of snarky_js_node.bc.js to 5.1 MB.

This is the spiritual successor to #11103, but is actually in a mergeable state.

$ ls -Alh _build/default/src/lib/snarky_js_bindings/snarky_js_node.bc.js
-r--r--r-- 1 matthew matthew 5.1M Jun  3 04:48 _build/default/src/lib/snarky_js_bindings/snarky_js_node.bc.js

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jun 3, 2022
@mrmr1993 mrmr1993 requested review from a team and imeckler as code owners June 3, 2022 03:52
@mrmr1993 mrmr1993 requested review from mitschabaude and a team as code owners June 3, 2022 05:41
@mrmr1993
Copy link
Member Author

mrmr1993 commented Jun 3, 2022

This works perfectly for me locally, but for some reason CI is still choking on it..

@mrmr1993
Copy link
Member Author

mrmr1993 commented Jun 3, 2022

Okay, CI should be happy now

Copy link
Member

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mrmr1993 mrmr1993 merged commit 9e293c7 into develop Jun 6, 2022
@mrmr1993 mrmr1993 deleted the feature/snarky-js-whole_program-compilation branch June 6, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants