Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better intg test exit codes #11196

Merged
merged 9 commits into from Jun 7, 2022
Merged

Conversation

QuiteStochastic
Copy link
Contributor

this way buildkite has more meaningful exit codes than simply just "1" for everything. mostly in accordance to Matthew's suggestions

@QuiteStochastic QuiteStochastic requested a review from a team as a code owner June 6, 2022 20:53
@QuiteStochastic QuiteStochastic added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jun 6, 2022
@mrmr1993
Copy link
Member

mrmr1993 commented Jun 7, 2022

Another exit code possibly worth tracking (from CI on this PR):

Some pods either were not assigned to nodes or did not deploy properly

Should be as simple as deciding on an error code and adding it here.

@mrmr1993 mrmr1993 merged commit ea4506c into compatible Jun 7, 2022
@mrmr1993 mrmr1993 deleted the better-intg-test-exit-codes branch June 7, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants