SnarkyJS proof recursion #11268
Merged
SnarkyJS proof recursion #11268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mitschabaude
commented
Jun 13, 2022
•
mitschabaude
commented
- Companion of Recursion Pt 1 o1-labs/o1js#245
- Adapts the Pickles interface of snarkyjs to support proof merging
- this also has the changes from Update snarkyjs & tweak build #11251, which wasn't reviewed so far. Those changes were minor, so we might just review them here and discard that other PR
- After a day-long debugging marathon, I made a change that overrides how jsoo handles uncaught exceptions: 650ca01 This is related insofar as it would've saved many hours of work on this PR if it were here before
mitschabaude
added
the
ci-build-me
mrmr1993
approved these changes
Jun 16, 2022
| @@ -1590,61 +1564,43 @@ let () = | |||
|
|
|||
| (* helpers for pickles_compile *) | |||
|
|
|||
| type 'a zkapp_statement = { transaction : 'a; at_party : 'a } | |||
| type 'a zkapp_statement = 'a array | |||
There was a problem hiding this comment.
Nit: It doesn't seem correct (and confused me at first) that this is still called zkapp_statement. Perhaps rename it to public_input / raw_statement / etc.?
|
|
||
| let zkapp_statement_to_fields { transaction; at_party } = | ||
| [| transaction; at_party |] | ||
| type zkapp_statement_js = field_class Js.t Js.js_array Js.t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.