More workers for faster proofs #11292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmr1993
approved these changes
Jun 15, 2022
mitschabaude
added
the
ci-build-me
|
love it, but bit of a code smell to mix imports into the code body, no? |
I agree! But this is not code where you can apply the normal standards of good JS style. Because it's bundled and transformed by js_of_ocaml which requires some special syntax. Putting it at the top level would require two extra annotations in comments, I think it's not worth it. |
|
Got it. ok 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the number of workers in the node version of snarkyjs, from 3 (hard-coded) to # of CPU cores - 1