Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support larger ledgers in IPC communication #11973

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Support larger ledgers in IPC communication #11973

merged 2 commits into from
Sep 13, 2023

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Oct 11, 2022 •
edited

Split larger messages on IPC to support larger ledger sizes.

Explain your changes:

  • When a large message is sent over a stream, split it to a few smaller

Explain how you tested your changes:

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues?

@georgeee georgeee changed the base branch from master to compatible October 11, 2022 16:20
@georgeee georgeee force-pushed the georgeee/raise-capnp-decode-max-message branch from e0b4e38 to d2e30d0 Compare October 11, 2022 16:27
@georgeee georgeee added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Oct 11, 2022
nholland94
nholland94 approved these changes Oct 17, 2022
View reviewed changes
src/lib/mina_net2/tests/tests.ml Outdated Show resolved Hide resolved
mrmr1993
mrmr1993 reviewed Oct 17, 2022
View reviewed changes
src/lib/mina_net2/libp2p_stream.ml Outdated Show resolved Hide resolved
src/lib/mina_net2/libp2p_stream.ml Show resolved Hide resolved
@georgeee georgeee force-pushed the georgeee/raise-capnp-decode-max-message branch from d2e30d0 to 97890e9 Compare November 7, 2022 16:24
@georgeee
Copy link
Member Author

georgeee commented Nov 7, 2022

!ci-build-me

@georgeee georgeee force-pushed the georgeee/raise-capnp-decode-max-message branch from 97890e9 to 2d23957 Compare November 18, 2022 17:32
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee georgeee force-pushed the georgeee/raise-capnp-decode-max-message branch from 2d23957 to dbfa9f0 Compare January 13, 2023 15:27
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee georgeee force-pushed the georgeee/raise-capnp-decode-max-message branch from dbfa9f0 to cd6e0c4 Compare August 26, 2023 07:01
@georgeee georgeee self-assigned this Aug 27, 2023
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee georgeee mentioned this pull request Aug 27, 2023
Closed
2 tasks
@georgeee georgeee force-pushed the georgeee/raise-capnp-decode-max-message branch from cd6e0c4 to 2af1c1c Compare August 28, 2023 11:48
@georgeee
Copy link
Member Author

!ci-build-me

mrmr1993
mrmr1993 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see nits

src/lib/mina_net2/libp2p_stream.ml Show resolved Hide resolved
src/lib/mina_net2/libp2p_stream.ml Show resolved Hide resolved
src/lib/mina_net2/libp2p_stream.ml Outdated Show resolved Hide resolved
src/lib/mina_net2/libp2p_stream.ml Outdated Show resolved Hide resolved
src/lib/mina_net2/tests/tests.ml Outdated Show resolved Hide resolved
@georgeee georgeee force-pushed the georgeee/raise-capnp-decode-max-message branch from 690b08a to 77d9a11 Compare August 29, 2023 21:09
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee georgeee force-pushed the georgeee/raise-capnp-decode-max-message branch 2 times, most recently from 34774ff to 43e550b Compare August 30, 2023 08:18
@georgeee
Copy link
Member Author

!ci-build-me

1 similar comment
@deepthiskumar
Copy link
Member

!ci-build-me

@georgeee georgeee force-pushed the georgeee/raise-capnp-decode-max-message branch from d003a2a to 87ae971 Compare September 12, 2023 19:43
@georgeee
Copy link
Member Author

!ci-build-me

2 similar comments
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee
Copy link
Member Author

!ci-build-me

@georgeee georgeee force-pushed the georgeee/raise-capnp-decode-max-message branch 2 times, most recently from 09105f6 to b313eae Compare September 13, 2023 14:31
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee georgeee force-pushed the georgeee/raise-capnp-decode-max-message branch from b313eae to 2bfe1eb Compare September 13, 2023 14:38
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee georgeee merged commit a7672da into compatible Sep 13, 2023
38 checks passed
@georgeee georgeee deleted the georgeee/raise-capnp-decode-max-message branch September 13, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@nholland94 nholland94 nholland94 approved these changes

@bkase bkase Awaiting requested review from bkase

@psteckler psteckler Awaiting requested review from psteckler

@imeckler imeckler Awaiting requested review from imeckler

Assignees

@georgeee georgeee

Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch proj-network-stability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@georgeee @deepthiskumar @mrmr1993 @nholland94