Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Memory_stats library #12904

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Remove Memory_stats library #12904

merged 5 commits into from
Sep 14, 2023

Conversation

mrmr1993
Copy link
Member

This PR removes the Memory_stats library, as part of the LowFillRate investigation.

This library was manually calling the garbage collector and dumping stats at regular intervals; previously we identified this as a source of slow-downs, but it appears that the code still remained in some places regardless.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 requested a review from a team as a code owner March 23, 2023 17:48
@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993
Copy link
Member Author

!ci-build-me

1 similar comment
@mrmr1993
Copy link
Member Author

mrmr1993 commented Apr 5, 2023

!ci-build-me

@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993
Copy link
Member Author

!ci-build-me

@psteckler psteckler merged commit 5eb58f2 into compatible Sep 14, 2023
38 checks passed
@psteckler psteckler deleted the feature/remove-memory-stats branch September 14, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants