Out-of-SNARK, use dummy vk hash when verification key is omitted #13394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
| @@ -1003,8 +1003,12 @@ module Make_str (A : Wire_types.Concrete) = struct | |||
| } | |||
|
|
|||
| let verification_key_hash (a : t) : Verification_key_hash.t = | |||
| verification_key a |> Zkapp_basic.Flagged_option.data | |||
| |> Data_as_hash.hash | |||
There was a problem hiding this comment.
The default hash is set here when converting between in-snark and outside-snark values.
The other side of the mismatch is here, the default is set to Field.zero in account updates.
It seems like we should update in either of these two places and not add a separate check as done in the PR. I'm leaning more towards updating the default value in account updates and have it be consistent across rest of the code base (use dummy vk hash) everywhere else.
Was that something you explored but found not to be suitable/working?
There was a problem hiding this comment.
Using the dummy vk hash is a better idea, thanks.
I'll update this PR.
psteckler
changed the title
|
!ci-build-me |
|
!ci-build-me |
mrmr1993
approved these changes
Jun 22, 2023
|
!ci-build-me |
|
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the zkApp transaction logic when running in-SNARK, there was a mismatch between the account update verification key hash and the account verification key hash when the vk was omitted (because the authorization was not Proof). Use
dummy_vk_hashin both cases.