Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snarkyjs by merging main into develop #13497

Closed

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Jun 28, 2023

As discussed with @mitschabaude, merging snarkyjs main into develop as new changes that must go into develop need to be built on top of changes in main.

Explain your changes:

  • Merge snarkyjs-bindings main into develop
  • Merge snarkyjs main into develop and use snarkyjs-bindings new develop branch.

Depends on o1-labs/o1js#1008 and o1-labs/o1js-bindings#61.

Explain how you tested your changes:

  • CI should pass

Checklist:

  • N/A Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • N/A Modified the current draft of release notes with details on what is completed or incomplete within this project
  • N/A Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • N/A Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • N/A Serialized types are in stable-versioned modules
  • N/A Does this close issues? List them
  • Closes #0000

@dannywillems dannywillems requested a review from a team as a code owner June 28, 2023 16:08
@dannywillems dannywillems force-pushed the dannywillems/merge-main-into-develop-snarkyjs branch from 74074ba to 712fa3d Compare June 28, 2023 16:09
@dannywillems
Copy link
Member Author

!ci-build-me

1 similar comment
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems
Copy link
Member Author

Old, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants