Use nonce for snark work and tx gossips #13535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [%%versioned | ||
| module Stable = struct | ||
| module V1 = struct | ||
| type 'a t = { message : 'a; nonce : int } [@@deriving compare, sexp, yojson] |
There was a problem hiding this comment.
Could you add a comment here describing why this is needed?
There was a problem hiding this comment.
Added the following comment:
Appending a nonce to messages emitted by transaction and snark pools allows to circumvent
libp2p's gossip deduplication logic and allow broadcasts to be broadcasted over and over again.
deepthiskumar
approved these changes
Jul 13, 2023
|
!ci-build-me |
|
Version linter failure is ok here as the changes were made to a V2 type |
nholland94
approved these changes
Jul 13, 2023
|
|
||
| let broadcast_snark_pool_diff t diff = | ||
| let broadcast_snark_pool_diff ?nonce t diff = |
There was a problem hiding this comment.
It's not set for initial broadcast (underlying layer will set 0 for it to be used in wire format).
There was a problem hiding this comment.
For rebroadcasts we generate a random number for a nonce
georgeee
force-pushed
the
georgeee/nonce-for-pool-gossips
branch
from
c43b3c3
to
c39fa10
Compare
|
!ci-build-me |
georgeee
force-pushed
the
georgeee/nonce-for-pool-gossips
branch
from
c39fa10
to
7a4650c
Compare
|
!ci-build-me |
Problem: with hash-based message ids rebroadcast mechanism became invalid. Solution: add integer nonce to snark/tx gossip messages in the old topic.
georgeee
force-pushed
the
georgeee/nonce-for-pool-gossips
branch
from
7a4650c
to
68c5c98
Compare
|
!ci-build-me |
|
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: with hash-based message ids rebroadcast mechanism became invalid.
Solution: add integer nonce to snark/tx gossip messages in the old topic.
Explain how you tested your changes:
Checklist: