Add bootstrap timeout #13747
Merged
Add bootstrap timeout #13747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!c--build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
1 similar comment
|
!ci-build-me |
src/lib/mina_lib/mina_lib.ml
Outdated
| | None -> | ||
| () | ||
| in | ||
| let handle_status_change state status = |
There was a problem hiding this comment.
Doesn't status here include Bootstrap based on how incremental_status is defined here ? How is state tracked?
There was a problem hiding this comment.
Yes, I got fooled by the type that merlin was reporting. We only need status.
|
!ci-build-me |
|
!ci-build-me |
dkijania
approved these changes
Aug 2, 2023
deepthiskumar
approved these changes
Aug 3, 2023
|
!ci-build-me |
|
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bootstrap timeout to the
Incrementalobserver. After 120 minutes, crash the daemon.Tested by
is_seedcondition increate_sync_status_observerSynced(which is almost instantaneous in the local seed node)Saw:
Closes #13728.