Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcode number of oversized logs #14286

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

ghost-not-in-the-shell
Copy link
Contributor

@ghost-not-in-the-shell ghost-not-in-the-shell commented Oct 6, 2023

Explain your changes:
This PR just hardcode number of oversized logs. We made such a decision because we want to avoid the circumstance that oversized logs eat too much disk spaces. And by experience, oversized log-rotation refresh slower than regular log-rotations.3 In the testing, we want to increase the number of log-rotation to be 500, and we want to leave most of the space for regular logs instead of having a lot of outdated oversized logs.

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

@nholland94
Copy link
Member

!approved-for-mainnet

@georgeee georgeee merged commit 0f1918f into berkeley Oct 9, 2023
25 checks passed
@georgeee georgeee deleted the hardcode-num-of-oversized-logs branch October 9, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants