statically link rocksdb #1433
Merged
statically link rocksdb #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emberian
force-pushed
the
fix/static-rocksdb
branch
from
2c2b3e1
to
05626f6
Compare
bkase
approved these changes
Jan 11, 2019
emberian
force-pushed
the
fix/static-rocksdb
branch
from
6fc1e13
to
7afaaae
Compare
to enable this on macOS, this replaces the original build system with dune. as part of this, it will build librocksdb.a on its own if /usr/local/lib/librocksdb_coda.a is not present on the system.
emberian
force-pushed
the
fix/static-rocksdb
branch
from
e6f119e
to
402dbe8
Compare
emberian
added a commit
that referenced
this pull request
Jan 14, 2019
This does changes similar to the ones made with rocksdb in #1433. This should make the snarky build work ootb with dune on macos.
This was referenced Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to enable this on macOS, this replaces the original
build system with dune. as part of this, it will build
librocksdb.a on its own if /usr/local/lib/librocksdb_coda.a
is not present on the system.