Format last_vrf_output as Base64 #14462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
georgeee
reviewed
Nov 1, 2023
| @@ -1845,7 +1845,7 @@ module User_command = struct | |||
| (Caqti_request.find typ Caqti_type.int | |||
| (Mina_caqti.insert_into_cols ~returning:"id" ~table_name | |||
| ~tannot:(function | |||
| | "typ" -> Some "user_command_type" | _ -> None ) | |||
| | "command_type" -> Some "user_command_type" | _ -> None ) | |||
There was a problem hiding this comment.
Is some renaming of typ to command_type happening behind the scenes?
There was a problem hiding this comment.
The current schema in create_schema.sql uses command_type in the user_commands table.
deepthiskumar
approved these changes
Nov 1, 2023
|
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same change was made in the migration app in #12906, which is against
berkeley. This is consistent with the formatting in precomputed blocks.This PR is against
rampup, in order to get this change for the next ITN deployment.I will add the hex-to-Base64 change to #14419, so the migration script will take care of this column.
Also: in the replayer, fixed a comment and removed an unused module.